Add various stubs for Intl #4819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
intl-various-stubs
branch
from
3a71d64 to
b5d14fc
Compare
nikic
approved these changes
Jan 3, 2020
| } | ||
|
|
||
| /** @return ResourceBundle|false|null */ | ||
| function resourcebundle_create(?string $locale, ?string $bundlename, bool $fallback = true) {} |
There was a problem hiding this comment.
: ResourceBundle|false|null should work now?
There was a problem hiding this comment.
Also, I don't think false is possible here?
There was a problem hiding this comment.
Yep, I am fixing this right now.
| */ | ||
| function resourcebundle_get(ResourceBundle $bundle, $index) {} | ||
|
|
||
| function resourcebundle_count(ResourceBundle $bundle): int|false {} |
There was a problem hiding this comment.
We should convert the "unconstructed" case into a hard Error exception in the future.
There was a problem hiding this comment.
I'd like this change! Will provide a PR sometime soon.
kocsismate
force-pushed
the
intl-various-stubs
branch
from
b5d14fc to
6bb9002
Compare
kocsismate
added a commit
to kocsismate/php-src
that referenced
this pull request
Jan 3, 2020
Closes phpGH-4819 - Add stubs for idn functions - Add stubs for grapheme functions - Add stubs for Spoofchecker - Add stubs for Normalizer - Add stubs for ResourceBundle - Fix arginfos - Add support for union return types - Fix arginfo for resourcebundle_create()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubs for the following components: