add some stubs for array func in basic_functions #4519
Conversation
|
I think it's better to stick with the existing arginfo parameter names. |
| @@ -60,6 +60,24 @@ function stream_wrapper_restore(string $protocol): bool {} | |||
| /** @return int|false */ | |||
| function array_push(array &$stack, ...$args) {} | |||
|
|
|||
| function krsort(array &$stack, int $sort_flags = PHP_SORT_REGULAR): bool {} | |||
There was a problem hiding this comment.
We can't typehint reference arguments. See #4501 (comment).
There was a problem hiding this comment.
Well, krsort() expects an array on entry, so in this case the type declaration should be fine.
|
|
||
| function count(mixed $array, int $mode = COUNT_NORAML): bool {} | ||
|
|
||
| function natsort(array &$stack){} |
There was a problem hiding this comment.
Missing return type.
There was a problem hiding this comment.
sorry, add void return type.
|
|
||
| function natsort(array &$stack){} | ||
|
|
||
| function natcasesort(array &$stack){} |
There was a problem hiding this comment.
Missing return type.
There was a problem hiding this comment.
sorry, add void return type.
|
|
||
| function ksort(array &$stack, int $sort_flags = PHP_SORT_REGULAR): bool {} | ||
|
|
||
| function count(mixed $array, int $mode = COUNT_NORAML): bool {} |
There was a problem hiding this comment.
mixed is not a valid type hint, moreover doesn't this need a doc comment @param array|Countable $array ?
There was a problem hiding this comment.
sorry, I've add doc comment @param array|Countable.
| @@ -66,9 +66,9 @@ function ksort(array &$stack, int $sort_flags = PHP_SORT_REGULAR): bool {} | |||
|
|
|||
| function count(mixed $array, int $mode = COUNT_NORAML): bool {} | |||
|
|
|||
| function natsort(array &$stack){} | |||
| function natsort(array &$stack): void {} | |||
There was a problem hiding this comment.
It is bool, but actually only TRUE will ever be returned. It might be sensible to change it to void, but that would be a BC break.
There was a problem hiding this comment.
@cmb69 Yeah, this goes to our list at https://bugs.php.net/bug.php?id=75958
|
Please have a look at the test failures. |
|
The test are failing because of #4519 (comment) |
thanks, I find a fail case in ext/reflection in ci log . |
jason-liew
force-pushed
the
add-array-php-stubs
branch
from
1a29b0e to
a829ed4
Compare
all test passed now, Please review again, Thanks. |
| @@ -60,6 +60,25 @@ function stream_wrapper_restore(string $protocol): bool {} | |||
| /** @return int|false */ | |||
| function array_push(array &$stack, ...$args) {} | |||
|
|
|||
| function krsort(array &$arg, int $sort_flags = PHP_SORT_REGULAR): bool {} | |||
There was a problem hiding this comment.
PHP_SORT_REGULAR is a C macro; its PHP pendant is SORT_REGULAR. I'm taking the liberty to fix that myself. :)
|
Thanks. Applied as ffffaf1. |
add stubs for array sort funcs in basic_functions