Skip to content

Add stubs for PCRE extension #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add stubs for PCRE extension #4501

wants to merge 5 commits into from

Conversation

stephenreay
Copy link
Contributor

Adding a stub for PCRE arginfo, following @nikic's request for participation.

carusogabriel
carusogabriel suggested changes Aug 10, 2019
View reviewed changes
nikic
nikic reviewed Aug 10, 2019
View reviewed changes
nikic
nikic reviewed Aug 10, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like sapi/cli/tests/006.phpt will need to be updated as well, because it is testing PCRE reflection output.

@php-pulls php-pulls closed this in 66b750d Aug 11, 2019
@nikic
Copy link
Member

nikic commented Aug 11, 2019

Merged together with updates to sapi/cli/tests/006.phpt. Thanks!

@stephenreay
Copy link
Contributor Author

Thank you!

@carusogabriel carusogabriel mentioned this pull request Aug 11, 2019
Closed
@cmb69 cmb69 added Stubs and removed Feature labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@carusogabriel carusogabriel carusogabriel requested changes

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenreay @nikic @carusogabriel @cmb69