Skip to content

Convert E_STRICT into E_NOTICE for htmlentities function in standard ext #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jul 14, 2019

Split from #4401 for htmlentities function.

@nikic
Copy link
Member

nikic commented Jul 15, 2019

This looks reasonable to me. I'll leave it open for a few days in case anyone else has feedback.

@nikic nikic added the Feature label Jul 15, 2019
@nikic nikic added this to the PHP 7.4 milestone Jul 18, 2019
@nikic
Copy link
Member

nikic commented Jul 18, 2019

Merged as 3a5664f.

@nikic nikic closed this Jul 18, 2019
@Girgias Girgias deleted the htmlentities-e-strict-conversion branch November 20, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants