Cleanup of remaning E_STRICT #4401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
e-strict-cleanup
branch
from
94dc3a1 to
106ee53
Compare
|
Can you please separate out the two changes that affect where E_STRICT is thrown? |
This was referenced Jul 14, 2019
Done :) |
Girgias
commented
Jul 15, 2019
Tobion
reviewed
Jul 17, 2019
nikic
reviewed
Jul 18, 2019
| @@ -3,8 +3,7 @@ foo = E_ALL E_NOTICE | |||
| error_reporting = E_ALL | |||
| error_reporting1 = E_COMPILE_ERROR|E_RECOVERABLE_ERROR |E_ERROR|E_CORE_ERROR | |||
| error_reporting2 = E_ALL&~E_NOTICE | |||
| error_reporting3 = E_ALL & ~E_NOTICE | |||
| error_reporting4 = E_ALL & ~E_NOTICE | E_STRICT | |||
There was a problem hiding this comment.
This should be kept with E_STRICT replaced with something else, I think. Possibly just a dummy value (if hex is supported, something like 0x100000), as this is a parsing test.
There was a problem hiding this comment.
There are a bunch of whitespaces after are those part of the test too?
Girgias
force-pushed
the
e-strict-cleanup
branch
2 times, most recently
from
26a1307 to
a1053d0
Compare
|
Closed and Reopened to restart CI after I messed up my rebase and it didn't pick up on the quick subsequent push Edit: nope just another file I missed after i f* the rebase onto upstream >__> |
Girgias
force-pushed
the
e-strict-cleanup
branch
from
a1053d0 to
53f0904
Compare
|
Windows test failure seems unrelated. |
|
Merged as 6d6d954, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed usage of E_STRICT in a couple of places by using lxr [1]
I've converted the last usages to
E_NOTICEhowever as @nikic is the author of the RFC to reclassify them [2] could you have a look at them?Removed the E_STRICT in the default error handling mode as this shouldn't trigger anything more now.
Not sure if we should keep the mention of E_STRICT in the INI files, I've removed them as they seem pointless ATM.
The constant still exists in the Zend engine which we may want to remove in PHP 8.
[1] https://lxr.room11.org/search?project=php-src%407.4&q=E_STRICT&defs=&refs=&path=&hist=&type=
[2] https://wiki.php.net/rfc/reclassify_e_strict