[7.2] Fix tests bareword fallback with error suppression #3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilliamxavier
referenced
this pull request
Feb 23, 2019
Access to undefined constants will now always result in an Error exception being thrown. This required quite a few test changes, because there were many buggy tests that unintentionally used bareword fallback in combination with error suppression.
|
I don't know, but in case you don't want to merge the whole thing (maybe because of the announced conflicts, or too many changes for the 7.2 branch), then what about picking just the |
|
I've committed the fix for bitwiseShiftLeft now. I'm leaving the rest alone, as we generally don't make test changes on release branches (unless they're failing...) |
guilliamxavier
deleted the
fix-tests-bareword-fallback-error-suppression-7.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3815 adapted for
PHP-7.2(diff:integer/booleanvsint/boolin error messages)Note: after merging this into
PHP-7.2, the merge ofPHP-7.2intoPHP-7.3will conflict on some modified files: the resolution is to simply discard them (the changes have already been merged in 7.3)