[7.3] Fix tests bareword fallback with error suppression #3815
Conversation
|
Merged as b3935ed, thanks :) |
|
@nikic Thanks for accepting =) but it looks like the subsequent merge (5ee1188) didn't change anything on the PHP-7.4 branch? I mean, the 13 |
|
/ping @nikic Should I open a new PR for 7.4 with just those 5 files? |
|
@guilliamxavier Yes please. I got confused here and thought the test changes were already in 7.4 rather than just master and did an |
|
Here it is: #3876 |
Access to undefined constants will now always result in an Error exception being thrown. This required quite a few test changes, because there were many buggy tests that unintentionally used bareword fallback in combination with error suppression.
guilliamxavier
deleted the
fix-tests-bareword-fallback-error-suppression-7.3
branch
aad3987#r32133606 (only the unintentionally buggy tests)
Notes:
ext/standard/tests/serialize/serialization_miscTypes_001.phptis considered a binary file, the change is just the same as forext/standard/tests/general_functions/debug_zval_dump_v.phpt(on line 84 instead of 105)PHP-7.3, the merge ofPHP-7.3intoPHP-7.4will conflict onext/standard/tests/array/*.phptdeleted files: the resolution is to simply discard them (i.e. re-delete them)