Skip to content

Sync UPGRADING.INTERNALS #15816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Sync UPGRADING.INTERNALS #15816

wants to merge 7 commits into from

Conversation

petk
Copy link
Member

@petk petk commented Sep 9, 2024

This sorts updates in UPGRADING.INTERNALS few steps forward:

  • configure options on top, then symbols, Autoconf macro changes grouped together, Zend header moved to Internal API changes, Autotools core changes moved to bottom

We still need to add that one/two Windows configure options. About adding these configure options to UPGRADING, it's not exactly my priority but I can check which should be added also there. Because, for example (--with-pspell configure option isn't really removed from the extension point of view but is removed from the php-src build system point of view).

[skip ci]

@cmb69
Copy link
Member

cmb69 commented Sep 9, 2024

Because, for example (--with-pspell configure option isn't really removed from the extension point of view but is removed from the php-src build system point of view).

I don't think we need to mention removal of configuration options of unbundled extension; it should be sufficient to document that these extensions have been unbundled.

@petk
Copy link
Member Author

petk commented Sep 9, 2024

Because, for example (--with-pspell configure option isn't really removed from the extension point of view but is removed from the php-src build system point of view).

I don't think we need to mention removal of configuration options of unbundled extension; it should be sufficient to document that these extensions have been unbundled.

Well configure --with-pspell done in PHP-8.4 outputs a warning and with ./configure --with-pspell --enable-option-checking=fatal fatal error happens. Every configure option changed since the previous version needs to be mentioned somewhere. Person building PHP can't tell from "pspell extension has been unbunbled and moved to PECL" that configure option is not available anymore. And with all these configure options confunsion is even greater.

@petk
[skip ci] Remove redundant mention of -Iflag for pdo_* extensions
7c6c2cd 
This was added as requested in the pull request
php#14444 but actually isn't important
to log like this here. Existing PHP extensions using PDO still have
their own way of adding the -I flag as before and aren't affected by
this change.
@petk petk mentioned this pull request Sep 10, 2024
Merged
@petk
Copy link
Member Author

petk commented Oct 19, 2024

All build system relevant changes that were important for me in this PR have been added to the evolution document here for now:
https://github.com/petk/php-build-system/blob/master/docs/evolution.md

I must say that it was very difficult to get the proper diff out of these UPGRADING and UPGRADING.INTERNALS documents for the past branches as they were inconsistently some here, some there, and some not even logged anywhere. Surprisingly the configure --help outputs work flawlessly for Autotools and Windows as they both show all configure options available for the given branch. Well at least I'm in the sync with these for the time being.

As PHP 8.4 is already branched, I'm closing this PR.

@petk petk closed this Oct 19, 2024
@petk petk deleted the patch-UPGRADING-INTERNALS-updates branch October 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @cmb69