Simplify PDO include paths #14444
Merged
Simplify PDO include paths #14444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDO include paths can be simplified and synced as done in other extensions: either the project root directory or the phpincludedir (for the system installation). The 'ext' include is automatically appended when doing phpize build. In php-src it is only present on Windows build. The PHP_CHECK_PDO_INCLUDES is left intact working as before and checks if PDO headers are found.
petk
requested review from
SakiTakamachi,
devnexen and
NattyNarwhal
as code owners
Girgias
approved these changes
Jun 2, 2024
NattyNarwhal
approved these changes
Jun 2, 2024
devnexen
approved these changes
Jun 3, 2024
|
Of course. I can add this to the upgrading file. Except that PDO extensions out there are not affected by this change. There is still the PHP_CHECK_PDO_INCLUDES macro available and creates the |
SakiTakamachi
approved these changes
Jun 3, 2024
petk
added a commit
to petk/php-src
that referenced
this pull request
Sep 10, 2024
This was added as requested in the pull request php#14444 but actually isn't important to log like this here. Existing PHP extensions using PDO still have their own way of adding the -I flag as before and aren't affected by this change.
|
Hello, I'm looking at the UPGRADING.INTERNALS change here again and basically this doesn't need to be noted in it. Because probably this wasn't clear enough back then that this change doesn't affect other PDO extensions out there. I'll remove the change in the changelog if you're all fine with this: #15816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDO include paths can be simplified and synced as done in other extensions: either the project root directory or the phpincludedir (for the system installation). The 'ext' include is automatically appended when doing phpize build. In php-src it is only present on Windows build. The PHP_CHECK_PDO_INCLUDES is left intact working as before and checks if PDO headers are found.
Unless I'm missing something that makes the pdo_* extensions different with these includes.