Close-GH 15685: improve proc_open error reporting on Windows #15687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While similar errors are already reported via `strerror()` on other platforms, this has apparently overlooked for Windows, where only the error code has been reported so far.
|
These error messages are localized on Windows, so there is the general question what to do about that in tests:
I prefer (1), but see valid arguments for (3); (2) is the best for controlled environments (like CI), but I consider it generally doubtful. |
We go with option (2), fow now.
|
In terms of tests, I would probably go for 3. |
Unfortunately, there is no PHP userland function which allows us to get the current system locale, so we work around.
Did this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While similar errors are already reported via
strerror()on other platforms, this has apparently overlooked for Windows, where only the error code has been reported so far.