Skip to content

improve proc_open error reporting on Windows #15685

Closed
@determin1st

Description

@determin1st

Description

i was launching processes recently and got a Warning: "CreateProcess failed with error code 8" that is generated here:

if (newprocok == FALSE) {

	if (newprocok == FALSE) {
		//DWORD dw = GetLastError();
		close_all_descriptors(descriptors, ndesc);
		//php_error_docref(NULL, E_WARNING, "CreateProcess failed, error code: %u", dw);
		php_win32_docref1_from_error(
			GetLastError(), ZSTR_VAL(command_str)
		);
		goto exit_fail;
	}

ive replaced php_error_docref function with windows specific function which said that was a lack of memory, instead of code 8. so kind of tested it.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions