Skip to content

Drop FASTCALL on variadic functions #15389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Drop FASTCALL on variadic functions #15389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Zend/zend_ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,15 +290,15 @@ ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_va(
return ast;
}

ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_n(unsigned kind, ...) {
ZEND_API zend_ast * zend_ast_create_n(unsigned kind, ...) {
va_list va;
va_start(va, kind);
zend_ast *ast = zend_ast_create_va(kind, 0, &va);
va_end(va);
return ast;
}

ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_ex_n(
ZEND_API zend_ast * zend_ast_create_ex_n(
zend_ast_kind kind, unsigned attr, ...) {
va_list va;
va_start(va, attr);
Expand Down
4 changes: 2 additions & 2 deletions Zend/zend_ast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,8 @@ ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_5(zend_ast_kind kind, zend_ast

ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_va(zend_ast_kind kind, zend_ast_attr attr, va_list *va);
/* Need to use unsigned args to avoid va promotion UB. */
ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_n(unsigned kind, ...);
ZEND_API zend_ast * ZEND_FASTCALL zend_ast_create_ex_n(zend_ast_kind kind, unsigned attr, ...);
ZEND_API zend_ast * zend_ast_create_n(unsigned kind, ...);
ZEND_API zend_ast * zend_ast_create_ex_n(zend_ast_kind kind, unsigned attr, ...);

static zend_always_inline zend_ast * zend_ast_create_ex_0(zend_ast_kind kind, zend_ast_attr attr) {
zend_ast *ast = zend_ast_create_0(kind);
Expand Down
Loading