Skip to content

Drop FASTCALL on variadic functions #15389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Aug 13, 2024

This is unlikely to be properly supported by compilers anyway, see #2975.

This is unlikely to be properly supported by compilers anyway, see
<php#2975>.
@cmb69
Copy link
Member Author

cmb69 commented Aug 13, 2024

This partially solves #15384.

@cmb69 cmb69 requested a review from iluuu1994 August 13, 2024 17:03
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cmb69 cmb69 merged commit 65c6d72 into php:master Aug 13, 2024
10 checks passed
@cmb69 cmb69 deleted the cmb/fastcall-variadic branch August 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants