Fix odbc_data_source_001.phpt #15254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.1.0, passing `null` to an `int` parameter is deprecated, and as such the deprecation notice breaks the test. So we instead pass an integer, and to avoid hard-coding a value we just add the two supported constants (which are supposed to have the values `1` and `2`, respectively).
NattyNarwhal
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.1.0, passing
nullto anintparameter is deprecated, and as such the deprecation notice breaks the test. So we instead pass an integer, and to avoid hard-coding a value we just add the two supported constants (which are supposed to have the values1and2, respectively).Note that this test is skipped in CI since no data sources are configured. Programatically configuring data sources (file data sources won't work) is possible, but would require some new code in ext/zend_test or fiddling with the registry manually. I don't think that running this test in CI justifies the required effort, though.