sapi/fpm: retiring solaris /dev/poll support proposal. #14685
Conversation
|
Not urgent, but I feel it s a low hanging fruit we really do not need anymore, Solaris 10 should be the minimum nowadays. |
|
Ah, good one in this case. This is then Solaris<10 check only. If so, then this can definitely be removed. Even Solaris 10 is in the process of becoming obsolete. Building software on it is already quite a challenge and to build PHP on some hypothetical Solaris pre-10 version will be almost to near impossible, I believe. Or at least not without lots of custom builds of dependencies and even compiler itself. I think we can drop everything related to Solaris<10 and focus more on Solaris 11.4 and illumos support with optional Solaris 10 adjustments what can still be done. I'm doing changes here #14681 and touching also this /dev/poll check. I hope it won't cause you issues to only rebase the PR... Thanks. |
|
Yes I ve seen your PR no worries I ll manage :) |
devnexen
force-pushed
the
solaris_dev_poll_removal
branch
from
9db195b to
07d1ded
Compare
|
@devnexen There's actually one old bug for /dev/poll in bug tracker with 128 votes: https://bugs.php.net/bug.php?id=65774 . It mentions SmartOS but it's been over 10 years since created. Are you that /dev/poll is not used anywhere and it is safe to remove? |
Since Solaris 10, the port API is supported, is more modern, less bug prone and offers, on average, better performances.
devnexen
force-pushed
the
solaris_dev_poll_removal
branch
from
07d1ded to
a8cbcae
Compare
|
I think so , no new report of usage since around 2013 indeed, this particular bug on solaris 10 from the ioctl DP_POLL part had been reported in other contexts like here, since Solaris and all flavor of Illumos support port api that would bring down to 1 native api per platform (beside poll/select). One less thing to update/clean for further php releases and so on. |
|
Don't forget to update UPGRADING |
|
A forgotten artefact removed via 90e63d8 |
|
And the https://bugs.php.net/bug.php?id=65774 can be probably removed then so it's clearer what is still open and relevant in the bugs.php.net. Edit: Bug has been closed now. |
Since Solaris 10, the port API is supported, is more modern, less bug prone and offers, on average, better performances.