Skip to content

Wrap FPM checks in AC_CACHE_CHECK and fix CS #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 26, 2024

  • This simplifies over-quoted arguments to AC_COMPILE_IFELSE
  • Indentation and other CS fixes
  • php_cv_* cache variables
  • AC_DEFINE help texts syncs to make it more clear
  • Fix -Wunused-but-set-variable warnings

To simplify the diff, append the ?w=1 to the files URL: https://github.com/php/php-src/pull/14681/files?w=1

petk added 2 commits June 26, 2024 23:18
- This simplifies over-quoted arguments to AC_COMPILE_IFELSE
- Indentation and other CS fixes
- php_cv_* cache variables
- AC_DEFINE help texts syncs to make it more clear
@petk petk requested a review from bukka as a code owner June 26, 2024 21:25
@petk petk changed the title Patch fpm ac cache check Wrap FPM checks in AC_CACHE_CHECK and fix CS Jun 26, 2024
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@petk petk merged commit c705dd8 into php:master Jun 27, 2024
10 of 11 checks passed
@petk petk deleted the patch-fpm-AC_CACHE_CHECK branch June 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants