Skip to content

Fix missing error restore code in ext-soap #14379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

Fix missing error restore code in ext-soap #14379

merged 1 commit into from
May 31, 2024

Conversation

nielsdos
Copy link
Member

The begin and end macros should be paired, but some of the end macro calls were missing.

@nielsdos nielsdos force-pushed the soap-error-code-1 branch from 095db77 to 6a65c0e Compare May 30, 2024 21:44
@nielsdos
Fix missing error restore code in ext-soap
6a65c0e 
The begin and end macros should be paired, but some of the end macro
calls were missing.
devnexen
devnexen approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@nielsdos nielsdos merged commit 6aa66e0 into php:PHP-8.2 May 31, 2024
8 of 9 checks passed
nielsdos added a commit that referenced this pull request May 31, 2024
@nielsdos
Merge branch 'PHP-8.2' into PHP-8.3
2b1097a 
* PHP-8.2:
  Fix reading zlib ini settings in ext-soap
  Fix memory leak if calling SoapServer::setClass() twice
  Fix memory leak if calling SoapServer::setObject() twice
  Fix missing error restore code in ext-soap (#14379)
  Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt (#14378)
nielsdos added a commit that referenced this pull request May 31, 2024
@nielsdos
Merge branch 'PHP-8.3'
a58c3a7 
* PHP-8.3:
  Fix reading zlib ini settings in ext-soap
  Fix memory leak if calling SoapServer::setClass() twice
  Fix memory leak if calling SoapServer::setObject() twice
  Fix missing error restore code in ext-soap (#14379)
  Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt (#14378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: soap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @devnexen @Girgias