Skip to content

Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt #14378

merged 1 commit into from
May 31, 2024

Conversation

nielsdos
Copy link
Member

If the runner overrides session.save_path, the test fails. Manually set it to a value known to trigger the issue.

@nielsdos nielsdos requested a review from Girgias as a code owner May 30, 2024 19:14
@nielsdos nielsdos linked an issue May 30, 2024 that may be closed by this pull request
Test failure in ext/session/tests/gh13856.phpt #14368
Closed
@nielsdos
Fix phpGH-14368: Test failure in ext/session/tests/gh13856.phpt
cb5ecfb 
If the runner overrides session.save_path, the test fails.
Manually set it to a value known to trigger the issue.
@nielsdos nielsdos merged commit d7aa0be into php:PHP-8.2 May 31, 2024
8 of 9 checks passed
nielsdos added a commit that referenced this pull request May 31, 2024
@nielsdos
Merge branch 'PHP-8.2' into PHP-8.3
2b1097a 
* PHP-8.2:
  Fix reading zlib ini settings in ext-soap
  Fix memory leak if calling SoapServer::setClass() twice
  Fix memory leak if calling SoapServer::setObject() twice
  Fix missing error restore code in ext-soap (#14379)
  Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt (#14378)
nielsdos added a commit that referenced this pull request May 31, 2024
@nielsdos
Merge branch 'PHP-8.3'
a58c3a7 
* PHP-8.3:
  Fix reading zlib ini settings in ext-soap
  Fix memory leak if calling SoapServer::setClass() twice
  Fix memory leak if calling SoapServer::setObject() twice
  Fix missing error restore code in ext-soap (#14379)
  Fix GH-14368: Test failure in ext/session/tests/gh13856.phpt (#14378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: session
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure in ext/session/tests/gh13856.phpt
2 participants
@nielsdos @Girgias