Skip to content

Check ext/pcntl required functions with for loop #14302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADING.INTERNALS
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
- Symbols HAVE_DLOPEN and HAVE_DLSYM have been removed.
- Symbol HAVE_MYSQL has been removed.
- Symbol HAVE_PDO_SQLITELIB has been removed.
- Symbol HAVE_WAITPID has been removed.
- M4 macro PHP_DEFINE (atomic includes) removed (use AC_DEFINE and config.h).
- M4 macro PHP_WITH_SHARED has been removed (use PHP_ARG_WITH).
- M4 macro PHP_STRUCT_FLOCK has been removed (use AC_CHECK_TYPES).
Expand Down
6 changes: 4 additions & 2 deletions ext/pcntl/config.m4
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ PHP_ARG_ENABLE([pcntl],
[Enable pcntl support (CLI/CGI only)])])

if test "$PHP_PCNTL" != "no"; then
AC_CHECK_FUNCS([fork waitpid sigaction],,
[AC_MSG_ERROR([ext/pcntl: required function $ac_func() not found.])])
for function in fork sigaction waitpid; do
AC_CHECK_FUNC([$function],,
[AC_MSG_ERROR([ext/pcntl: required function $function() not found.])])
done

AC_CHECK_FUNCS(m4_normalize([
forkx
Expand Down