Check ext/pcntl required functions with for loop #14302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This omits defining redundant HAVE_<function> symbols since these are used unconditionally in ext/pcntl. * HAVE_FORK is defined via ext/standard/config.m4 * HAVE_SIGACTION is defined via Zend.m4 * HAVE_WAITPID symbol is removed
Indeed. HAVE_WAITPID is not used in php-src, and quick scan if some PHP extension might be using this symbol in a wrong way, also none. |
|
Rechecked and all looks good here. I'll merge this in the following days. cc @devnexen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This omits defining redundant HAVE_ symbols since these are used unconditionally in ext/pcntl.