Skip to content

Fix message for skipping tests for SSL 3.2 #14025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix message for skipping tests for SSL 3.2 #14025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/openssl/tests/openssl_x509_parse_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ openssl_x509_parse() tests
openssl
--SKIPIF--
<?php
if (OPENSSL_VERSION_NUMBER >= 0x30200000) die('skip For OpenSSL < 3.2');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip is not part of the message. So it's saying that this test is for OpenSSL < 3.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. I read it literally that the "test is skipped for OpenSSL < 3.2". There are a few cases in the codebase with reversed logic. I wonder why this format was chosen. Anyway, I close the PR, sorry for the misunderstanding.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Yeah it's a bit confusing. I'm not sure how to improve it. Some tests add skip - Message as a separator, but this will result in a weird message (i.e. - Message). So I would just keep it as is for now.

if (OPENSSL_VERSION_NUMBER >= 0x30200000) die('skip For OpenSSL >= 3.2');
?>
--FILE--
<?php
Expand Down
2 changes: 1 addition & 1 deletion ext/openssl/tests/openssl_x509_parse_basic_openssl32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ openssl_x509_parse() tests
openssl
--SKIPIF--
<?php
if (OPENSSL_VERSION_NUMBER < 0x30200000) die('skip For OpenSSL >= 3.2');
if (OPENSSL_VERSION_NUMBER < 0x30200000) die('skip For OpenSSL < 3.2');
?>
--FILE--
<?php
Expand Down