Fix message for skipping tests for SSL 3.2 #14025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Apr 20, 2024
| @@ -4,7 +4,7 @@ openssl_x509_parse() tests | |||
| openssl | |||
| --SKIPIF-- | |||
| <?php | |||
| if (OPENSSL_VERSION_NUMBER >= 0x30200000) die('skip For OpenSSL < 3.2'); | |||
There was a problem hiding this comment.
The skip is not part of the message. So it's saying that this test is for OpenSSL < 3.2.
There was a problem hiding this comment.
I understand. I read it literally that the "test is skipped for OpenSSL < 3.2". There are a few cases in the codebase with reversed logic. I wonder why this format was chosen. Anyway, I close the PR, sorry for the misunderstanding.
There was a problem hiding this comment.
No worries. Yeah it's a bit confusing. I'm not sure how to improve it. Some tests add skip - Message as a separator, but this will result in a weird message (i.e. - Message). So I would just keep it as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages for the PR were reversed: #13961