-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[RFC] Deprecate implicit nullable parameter types #12959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kocsismate
merged 1 commit into
php:master
from
kocsismate:deprecate-implicit-nullability
Mar 13, 2024
Merged
[RFC] Deprecate implicit nullable parameter types #12959
kocsismate
merged 1 commit into
php:master
from
kocsismate:deprecate-implicit-nullability
Mar 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
808ffa6
to
abdf8b2
Compare
00e1b5f
to
239a2b4
Compare
Girgias
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, still drafting the RFC
Zend/tests/variadic/adding_additional_optional_parameter_error.phpt
Outdated
Show resolved
Hide resolved
Girgias
reviewed
Dec 23, 2023
8bc9363
to
7ed7137
Compare
7ed7137
to
f644467
Compare
f644467
to
0c855aa
Compare
RFC: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types Co-authored-by: Gina Peter Banyard <girgias@php.net>
0c855aa
to
0248ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types