Address review comments

Author: kocsismate

Zend/tests/type_declarations/scalar_null.phpt

@@ -8,10 +8,10 @@ $functions = [
     'float' => function (float $f) { return $f; },
     'string' => function (string $s) { return $s; },
     'bool' => function (bool $b) { return $b; },
-    'int nullable' => function (?int $i = NULL) { return $i; },
-    'float nullable' => function (?float $f = NULL) { return $f; },
-    'string nullable' => function (?string $s = NULL) { return $s; },
-    'bool nullable' => function (?bool $b = NULL) { return $b; }
+    'int nullable' => function (?int $i) { return $i; },
+    'float nullable' => function (?float $f) { return $f; },
+    'string nullable' => function (?string $s) { return $s; },
+    'bool nullable' => function (?bool $b) { return $b; }
 ];
 
 foreach ($functions as $type => $function) {

Zend/tests/variadic/adding_additional_optional_parameter.phpt

@@ -8,11 +8,10 @@ interface DB {
 }
 
 class MySQL implements DB {
-    public function query($query, string $extraParam = null, string ...$params) { }
+    public function query($query, ?string $extraParam = null, string ...$params) { }
 }
 
 ?>
 ===DONE===
 --EXPECTF--
-Deprecated: Implicitly marking parameter $extraParam as nullable is deprecated, the explicit nullable type must be used instead in %s on line %d
 ===DONE===

Zend/tests/variadic/adding_additional_optional_parameter_error.phpt

@@ -8,11 +8,9 @@ interface DB {
 }
 
 class MySQL implements DB {
-    public function query($query, int $extraParam = null, string ...$params) { }
+    public function query($query, ?int $extraParam = null, string ...$params) { }
 }
 
 ?>
 --EXPECTF--
-Deprecated: Implicitly marking parameter $extraParam as nullable is deprecated, the explicit nullable type must be used instead in %s on line %d
-
 Fatal error: Declaration of MySQL::query($query, ?int $extraParam = null, string ...$params) must be compatible with DB::query($query, string ...$params) in %s on line %d

ext/reflection/tests/ReflectionClass_export_basic1.phpt

@@ -11,7 +11,7 @@ Class A {
                          $e = "15 chars long -",
                          $f = null,
                          $g = false,
-                         ?array $h = null) {}
+                         array $h = null) {}
 }
 
 Class C extends A { }
@@ -20,6 +20,7 @@ define('K', "16 chars long --");
 echo new ReflectionClass("C"), "\n";
 ?>
 --EXPECTF--
+Deprecated: Implicitly marking parameter $h as nullable is deprecated, the explicit nullable type must be used instead in %s on line %d
 Class [ <user> class C extends A ] {
   @@ %s 14-14
 

ext/reflection/tests/parameters_002.phpt

@@ -11,7 +11,7 @@ function test($nix, Array $ar, &$ref, stdClass $std,
 class test
 {
     function method($nix, Array $ar, &$ref, stdClass $std,
-        NonExistingClass $na, stdClass $opt = NULL, $def = "FooBar")
+        NonExistingClass $na, ?stdClass $opt = NULL, $def = "FooBar")
     {
     }
 }
@@ -73,8 +73,6 @@ check_params(ReflectionMethod::createFromMethodName('test::method'));
 
 ?>
 --EXPECTF--
-Deprecated: Implicitly marking parameter $opt as nullable is deprecated, the explicit nullable type must be used instead in %s on line %d
-
 Deprecated: Implicitly marking parameter $opt as nullable is deprecated, the explicit nullable type must be used instead in %s on line %d
 #####test()#####
 ===0===