Skip to content

Commit 866aa12

Browse files
SakiTakamachiSakiTakamachi
authored
ext/pdo: Fixed PDO::setAttribute() and PDO::getAttribute() (#12793)
1 parent e502aaf commit 866aa12

17 files changed

+104
-46
lines changed

‎NEWS

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,18 @@ Opcache:
3434
. If JIT is enabled, PHP will now exit with a fatal error on startup in case
3535
of JIT startup initialization issues. (danog)
3636

37+
PDO:
38+
. Fixed setAttribute and getAttribute (SakiTakamachi)
39+
40+
PDO_DBLIB:
41+
. Fixed setAttribute and getAttribute (SakiTakamachi)
42+
43+
PDO_FIREBIRD:
44+
. Fixed setAttribute and getAttribute (SakiTakamachi)
45+
46+
PDO_MYSQL:
47+
. Fixed setAttribute and getAttribute (SakiTakamachi)
48+
3749
PDO_PGSQL:
3850
. Fixed GH-12423, DSN credentials being prioritized over the user/password
3951
PDO constructor arguments. (SakiTakamachi)

‎UPGRADING

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,17 @@ PHP 8.4 UPGRADE NOTES
2626
Consult sections 2. New Features and 6. New Functions for a list of
2727
newly implemented methods and constants.
2828

29+
- PDO_DBLIB:
30+
. setAttribute, DBLIB_ATTR_STRINGIFY_UNIQUEIDENTIFIER and DBLIB_ATTR_DATETIME_CONVERT
31+
have been changed to set value as a bool.
32+
33+
- PDO_FIREBIRD:
34+
. getAttribute, ATTR_AUTOCOMMIT has been changed to get the value as a bool.
35+
36+
- PDO_MYSQL:
37+
. getAttribute, ATTR_AUTOCOMMIT, ATTR_EMULATE_PREPARES, MYSQL_ATTR_DIRECT_QUERY have
38+
been changed to get values ​​as bool.
39+
2940
- PDO_PGSQL:
3041
. The DSN's credentials, when set, are given priority over their PDO
3142
constructor counterparts, being closer to the documentation states.
@@ -139,6 +150,16 @@ PHP 8.4 UPGRADE NOTES
139150
. The behavior of mb_strcut is more consistent now on invalid UTF-8 and UTF-16
140151
strings. (For valid UTF-8 and UTF-16 strings, there is no change.)
141152

153+
- PDO:
154+
. getAttribute, enabled to get the value of ATTR_STRINGIFY_FETCHES.
155+
156+
- PDO_FIREBIRD:
157+
. getAttribute, enabled to get values ​​of FB_ATTR_DATE_FORMAT, FB_ATTR_TIME_FORMAT,
158+
FB_ATTR_TIMESTAMP_FORMAT.
159+
160+
- PDO_MYSQL:
161+
. getAttribute, enabled to get the value of ATTR_FETCH_TABLE_NAMES.
162+
142163
- PGSQL:
143164
. pg_select, the conditions arguments accepts an empty array and is optional.
144165

‎ext/pdo/pdo_dbh.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -911,8 +911,13 @@ PHP_METHOD(PDO, getAttribute)
911911
add_next_index_zval(return_value, &dbh->def_stmt_ctor_args);
912912
}
913913
return;
914+
914915
case PDO_ATTR_DEFAULT_FETCH_MODE:
915916
RETURN_LONG(dbh->default_fetch_type);
917+
918+
case PDO_ATTR_STRINGIFY_FETCHES:
919+
RETURN_BOOL(dbh->stringify);
920+
916921
default:
917922
break;
918923
}

‎ext/pdo_dblib/dblib_driver.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,10 @@ static bool dblib_set_attr(pdo_dbh_t *dbh, zend_long attr, zval *val)
290290
}
291291
return SUCCEED == dbsettime(lval);
292292
case PDO_DBLIB_ATTR_STRINGIFY_UNIQUEIDENTIFIER:
293-
if (!pdo_get_long_param(&lval, val)) {
293+
if (!pdo_get_bool_param(&bval, val)) {
294294
return false;
295295
}
296-
H->stringify_uniqueidentifier = lval;
296+
H->stringify_uniqueidentifier = bval;
297297
return true;
298298
case PDO_DBLIB_ATTR_SKIP_EMPTY_ROWSETS:
299299
if (!pdo_get_bool_param(&bval, val)) {
@@ -302,10 +302,10 @@ static bool dblib_set_attr(pdo_dbh_t *dbh, zend_long attr, zval *val)
302302
H->skip_empty_rowsets = bval;
303303
return true;
304304
case PDO_DBLIB_ATTR_DATETIME_CONVERT:
305-
if (!pdo_get_long_param(&lval, val)) {
305+
if (!pdo_get_bool_param(&bval, val)) {
306306
return false;
307307
}
308-
H->datetime_convert = lval;
308+
H->datetime_convert = bval;
309309
return true;
310310
default:
311311
return false;

‎ext/pdo_firebird/firebird_driver.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1080,7 +1080,7 @@ static int pdo_firebird_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
10801080
char tmp[INFO_BUF_LEN];
10811081

10821082
case PDO_ATTR_AUTOCOMMIT:
1083-
ZVAL_LONG(val,dbh->auto_commit);
1083+
ZVAL_BOOL(val,dbh->auto_commit);
10841084
return 1;
10851085

10861086
case PDO_ATTR_CONNECTION_STATUS:
@@ -1124,6 +1124,18 @@ static int pdo_firebird_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
11241124
case PDO_ATTR_FETCH_TABLE_NAMES:
11251125
ZVAL_BOOL(val, H->fetch_table_names);
11261126
return 1;
1127+
1128+
case PDO_FB_ATTR_DATE_FORMAT:
1129+
ZVAL_STRING(val, H->date_format);
1130+
return 1;
1131+
1132+
case PDO_FB_ATTR_TIME_FORMAT:
1133+
ZVAL_STRING(val, H->time_format);
1134+
return 1;
1135+
1136+
case PDO_FB_ATTR_TIMESTAMP_FORMAT:
1137+
ZVAL_STRING(val, H->timestamp_format);
1138+
return 1;
11271139
}
11281140
return 0;
11291141
}

‎ext/pdo_firebird/tests/autocommit_change_mode.phpt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -91,42 +91,42 @@ echo "done!";
9191
--EXPECT--
9292
========== not in manually transaction ==========
9393
auto commit ON from ON
94-
int(1)
94+
bool(true)
9595
Success
9696

9797
auto commit OFF from ON
98-
int(0)
98+
bool(false)
9999
Success
100100

101101
auto commit OFF from OFF
102-
int(0)
102+
bool(false)
103103
Success
104104

105105
auto commit ON from OFF
106-
int(1)
106+
bool(true)
107107
Success
108108

109109
========== in manually transaction ==========
110110
begin transaction
111111

112112
auto commit ON from ON, expect error
113-
int(1)
113+
bool(true)
114114
SQLSTATE[HY000]: General error: Cannot change autocommit mode while a transaction is already open
115115

116116
auto commit OFF from ON, expect error
117-
int(1)
117+
bool(true)
118118
SQLSTATE[HY000]: General error: Cannot change autocommit mode while a transaction is already open
119119

120120
end transaction
121121
auto commit OFF
122122
begin transaction
123123

124124
auto commit ON from OFF, expect error
125-
int(0)
125+
bool(false)
126126
SQLSTATE[HY000]: General error: Cannot change autocommit mode while a transaction is already open
127127

128128
auto commit OFF from OFF, expect error
129-
int(0)
129+
bool(false)
130130
SQLSTATE[HY000]: General error: Cannot change autocommit mode while a transaction is already open
131131

132132
end transaction

‎ext/pdo_mysql/mysql_driver.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ static int pdo_mysql_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_
532532
break;
533533

534534
case PDO_ATTR_AUTOCOMMIT:
535-
ZVAL_LONG(return_value, dbh->auto_commit);
535+
ZVAL_BOOL(return_value, dbh->auto_commit);
536536
break;
537537

538538
case PDO_ATTR_DEFAULT_STR_PARAM:
@@ -545,7 +545,7 @@ static int pdo_mysql_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_
545545

546546
case PDO_ATTR_EMULATE_PREPARES:
547547
case PDO_MYSQL_ATTR_DIRECT_QUERY:
548-
ZVAL_LONG(return_value, H->emulate_prepare);
548+
ZVAL_BOOL(return_value, H->emulate_prepare);
549549
break;
550550

551551
#ifndef PDO_USE_MYSQLND
@@ -576,6 +576,10 @@ static int pdo_mysql_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_
576576
}
577577
#endif
578578

579+
case PDO_ATTR_FETCH_TABLE_NAMES:
580+
ZVAL_BOOL(return_value, H->fetch_table_names);
581+
break;
582+
579583
default:
580584
PDO_DBG_RETURN(0);
581585
}

‎ext/pdo_mysql/tests/bug68371.phpt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ $pdo->setAttribute (\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
1515

1616
$attrs = [
1717
// Extensive test: default value and set+get values
18-
PDO::ATTR_EMULATE_PREPARES => array(null, 1, 0),
19-
PDO::MYSQL_ATTR_DIRECT_QUERY => array(null, 0, 1),
18+
PDO::ATTR_EMULATE_PREPARES => array(null, true, false),
19+
PDO::MYSQL_ATTR_DIRECT_QUERY => array(null, false, true),
2020
PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => array(null, false, true),
2121

2222
// Just test the default
@@ -67,16 +67,16 @@ foreach ($attrs as $a => $vals) {
6767

6868
?>
6969
--EXPECTF--
70-
int(1)
70+
bool(true)
7171
OK
7272
OK
73-
int(0)
73+
bool(false)
7474
OK
7575
OK
7676
bool(true)
7777
OK
7878
OK
79-
int(1)
79+
bool(true)
8080
ERR
8181
ERR
8282
int(2)
@@ -93,9 +93,9 @@ array(1) {
9393
[0]=>
9494
string(12) "PDOStatement"
9595
}
96-
ERR
96+
bool(false)
9797
ERR
9898
string(5) "mysql"
99-
ERR
99+
bool(false)
100100
ERR
101101
int(4)

‎ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ MySQLPDOTest::skip();
5454

5555
$defaults = [
5656
PDO::ATTR_PERSISTENT => false,
57-
PDO::ATTR_AUTOCOMMIT => 1,
57+
PDO::ATTR_AUTOCOMMIT => true,
5858
/* TODO - why is this a valid option if getAttribute() does not support it?! */
5959
PDO::ATTR_TIMEOUT => false,
60-
PDO::ATTR_EMULATE_PREPARES => 1,
60+
PDO::ATTR_EMULATE_PREPARES => true,
6161
PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => true,
6262
/* TODO getAttribute() does not handle it */
6363
PDO::MYSQL_ATTR_LOCAL_INFILE => false,
6464
/* TODO getAttribute() does not handle it */
65-
PDO::MYSQL_ATTR_DIRECT_QUERY => 1,
65+
PDO::MYSQL_ATTR_DIRECT_QUERY => true,
6666
PDO::MYSQL_ATTR_INIT_COMMAND => '',
6767
];
6868

@@ -151,8 +151,8 @@ MySQLPDOTest::skip();
151151
set_option_and_check(24, PDO::MYSQL_ATTR_INIT_COMMAND, '', 'PDO::MYSQL_ATTR_INIT_COMMAND');
152152
set_option_and_check(25, PDO::MYSQL_ATTR_INIT_COMMAND, 'INSERT INTO nonexistent(invalid) VALUES (1)', 'PDO::MYSQL_ATTR_INIT_COMMAND');
153153

154-
set_option_and_check(33, PDO::MYSQL_ATTR_DIRECT_QUERY, 1, 'PDO::MYSQL_ATTR_DIRECT_QUERY');
155-
set_option_and_check(34, PDO::MYSQL_ATTR_DIRECT_QUERY, 0, 'PDO::MYSQL_ATTR_DIRECT_QUERY');
154+
set_option_and_check(33, PDO::MYSQL_ATTR_DIRECT_QUERY, true, 'PDO::MYSQL_ATTR_DIRECT_QUERY');
155+
set_option_and_check(34, PDO::MYSQL_ATTR_DIRECT_QUERY, false, 'PDO::MYSQL_ATTR_DIRECT_QUERY');
156156

157157
if (defined('PDO::MYSQL_ATTR_LOCAL_INFILE_DIRECTORY')) {
158158
set_option_and_check(35, PDO::MYSQL_ATTR_LOCAL_INFILE_DIRECTORY, null, 'PDO::MYSQL_ATTR_LOCAL_INFILE_DIRECTORY');

‎ext/pdo_mysql/tests/pdo_mysql_attr_autocommit.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ MySQLPDOTest::skip();
1313
$db = MySQLPDOTest::factory();
1414

1515
// autocommit should be on by default
16-
if (1 !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
16+
if (true !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
1717
printf("[001] Expecting int/1 got %s\n", var_export($tmp, true));
1818

1919
// lets see if the server agrees to that
@@ -33,7 +33,7 @@ MySQLPDOTest::skip();
3333
if (!$db->query('SET autocommit = 1'))
3434
printf("[005] Cannot turn on server autocommit mode, %s\n", var_export($db->errorInfo(), true));
3535

36-
if (0 !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
36+
if (false !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
3737
printf("[006] Expecting int/0 got %s\n", var_export($tmp, true));
3838

3939
// off -> on
@@ -47,7 +47,7 @@ MySQLPDOTest::skip();
4747
if (!$row['_autocommit'])
4848
printf("[009] Server autocommit mode should be on, got '%s'\n", var_export($row['_autocommit']));
4949

50-
if (1 !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
50+
if (true !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
5151
printf("[010] Expecting int/1 got %s\n", var_export($tmp, true));
5252

5353
$table = 'pdo_mysql_attr_autocommit';

‎ext/pdo_mysql/tests/pdo_mysql_attr_fetch_table_names.phpt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@ MySQLPDOTest::skip();
1515
$table = 'pdo_mysql_attr_fetch_table_names';
1616
MySQLPDOTest::createTestTable($table, $db);
1717

18-
$db->setAttribute(PDO::ATTR_FETCH_TABLE_NAMES, 1);
18+
$db->setAttribute(PDO::ATTR_FETCH_TABLE_NAMES, true);
19+
var_dump($db->getAttribute(PDO::ATTR_FETCH_TABLE_NAMES));
1920
$stmt = $db->query("SELECT label FROM {$table} LIMIT 1");
2021
var_dump($stmt->fetchAll(PDO::FETCH_ASSOC));
2122
$stmt->closeCursor();
2223

23-
$db->setAttribute(PDO::ATTR_FETCH_TABLE_NAMES, 0);
24+
$db->setAttribute(PDO::ATTR_FETCH_TABLE_NAMES, false);
25+
var_dump($db->getAttribute(PDO::ATTR_FETCH_TABLE_NAMES));
2426
$stmt = $db->query("SELECT label FROM {$table} LIMIT 1");
2527
var_dump($stmt->fetchAll(PDO::FETCH_ASSOC));
2628
$stmt->closeCursor();
@@ -34,13 +36,15 @@ $db = MySQLPDOTest::factory();
3436
$db->query('DROP TABLE IF EXISTS pdo_mysql_attr_fetch_table_names');
3537
?>
3638
--EXPECT--
39+
bool(true)
3740
array(1) {
3841
[0]=>
3942
array(1) {
4043
["pdo_mysql_attr_fetch_table_names.label"]=>
4144
string(1) "a"
4245
}
4346
}
47+
bool(false)
4448
array(1) {
4549
[0]=>
4650
array(1) {

‎ext/pdo_mysql/tests/pdo_mysql_begintransaction.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ MySQLPDOTest::skipNotTransactionalEngine();
1616

1717
MySQLPDOTest::createTestTable($table, $db, MySQLPDOTest::detect_transactional_mysql_engine($db));
1818

19-
if (1 !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
19+
if (true !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
2020
printf("[001] Autocommit should be on by default\n");
2121

2222
if (false == $db->beginTransaction())
2323
printf("[002] Cannot start a transaction, [%s] [%s]\n",
2424
$db->errorCode(), implode(' ', $db->errorInfo()));
2525

26-
if (1 !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
26+
if (true !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
2727
printf("[003] Autocommit should be on by default, beginTransaction() shall not impact it\n");
2828

2929
if (0 == $db->exec("DELETE FROM {$table}"))
@@ -50,7 +50,7 @@ MySQLPDOTest::skipNotTransactionalEngine();
5050
if (!$db->commit())
5151
printf("[008] [%s] %s\n", $db->errorCode(), implode(' ', $db->errorInfo()));
5252

53-
if (1 !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
53+
if (true !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
5454
printf("[009] Autocommit should be on after commit()\n");
5555

5656
if (!($stmt = $db->query(sprintf('SELECT id, label FROM %s WHERE id = %d', $table, $row['id']))))
@@ -91,7 +91,7 @@ MySQLPDOTest::skipNotTransactionalEngine();
9191
if (!$db->rollback())
9292
printf("[018] [%s] %s\n", $db->errorCode(), implode(' ', $db->errorInfo()));
9393

94-
if (1 !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
94+
if (true !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
9595
printf("[019] Autocommit should be on after rollback\n");
9696

9797
if (!($stmt = $db->query(sprintf('SELECT id, label FROM %s WHERE id = %d', $table, $row['id']))))
@@ -132,7 +132,7 @@ MySQLPDOTest::skipNotTransactionalEngine();
132132

133133
// Turn off autocommit using a server variable
134134
$db->exec('SET @@autocommit = 0');
135-
if (1 === $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
135+
if (true === $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
136136
printf("[028] I'm confused, how can autocommit be on? Didn't I say I want to manually control transactions?\n");
137137

138138
if (!$db->beginTransaction())
@@ -155,7 +155,7 @@ MySQLPDOTest::skipNotTransactionalEngine();
155155
printf("[031] Cannot start a transaction, [%s] [%s]\n",
156156
$db->errorCode(), implode(' ', $db->errorInfo()));
157157

158-
if (1 !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
158+
if (true !== $db->getAttribute(PDO::ATTR_AUTOCOMMIT))
159159
printf("[032] Autocommit should be on my default, beginTransaction() should not change that\n");
160160

161161
if (0 == $db->exec("DELETE FROM {$table}"))

‎ext/pdo_mysql/tests/pdo_mysql_commit.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ MySQLPDOTest::skipNotTransactionalEngine();
3535

3636
// pdo_transaction_transitions should check this as well...
3737
// ... just to be sure the most basic stuff really works we check it again...
38-
if (1 !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
38+
if (true !== ($tmp = $db->getAttribute(PDO::ATTR_AUTOCOMMIT)))
3939
printf("[003] According to the manual we should be back to autocommit mode, got %s/%s\n",
4040
gettype($tmp), var_export($tmp, true));
4141

0 commit comments

Comments
 (0)