Separate setting of SO_KEEPALIVE in FPM tests #12640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
fpm_test_separate_socket_keepalive
branch
from
3cef1de to
b8af49e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting of
SO_KEEPALIVEhas been done on any fcgi connection keepalive setting which is not necessary and it requires socket extension to be present. This PR separates it which makes more sense. Setting of$socketKeepAliveautomatically sets$connKeepAliveso it will be necessary to set just one option ifSO_KEEPALIVEneeded for test.