Fix bug #76922: FastCGI terminates conn after FCGI_GET_VALUES #12387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
fpm_fcgi_get_values_conn_rst
branch
from
73cd95d to
3dd3890
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Nov 2, 2023
bukka
force-pushed
the
fpm_fcgi_get_values_conn_rst
branch
from
3dd3890 to
fe36f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense not to abort connection after getting values as it is a management record as most records.
Targeting just 8.2 as I'm not completely sure if it's a bug. I might need to re-reread the spec again but only 8.2 should be fine.