Do only not escape twit filter output when EditInPlace is false #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Jun 15, 2017
| @@ -35,7 +35,7 @@ | |||
| "matthiasnoback/symfony-dependency-injection-test": "^1.0", | |||
| "guzzlehttp/psr7": "^1.3", | |||
| "nyholm/nsa": "^1.0", | |||
| "nyholm/symfony-bundle-test": "^1.0.1" | |||
| "nyholm/symfony-bundle-test": "^1.0.2" | |||
There was a problem hiding this comment.
This will fix:
Symfony\Component\DependencyInjection\Exception\LogicException: Annotations cannot be enabled as the Doctrine Cache library is not installed.
rvanlaak
approved these changes
Jun 15, 2017
Twig/TranslationExtension.php
Outdated
| $value = $this->transchoice($message, $count, $arguments, $domain, $locale); | ||
|
|
||
| if ($this->escapeOutput()) { | ||
| return twig_escape_filter($env, $value, 'html', null, true); |
There was a problem hiding this comment.
Exept for the double space here, this PR is just perfect! 🎉
There was a problem hiding this comment.
Thank you. I thought StyleCI would fix that.
(Friendly ping) Maybe @GrahamCampbell wants to know about this.
|
Nice solution 👍 Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #100 and replace #101