Skip to content

Do not "override" Twig trans filters as being html safe #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rvanlaak
Copy link
Member

as that conflicts with the behavior in environments where debug = false.

Fixes #100

as that conflicts with the behavior in environments where `debug = false`
@rvanlaak
Copy link
Member Author

Symfony\Component\DependencyInjection\Exception\LogicException: Annotations cannot be enabled as the Doctrine Cache library is not installed.

Where is this failing test exception about?

@damienalexandre
Copy link
Contributor

Is there an issue with this option? This is needed for the EditInPlace feature - see the docblock here - as we inject HTML before and after the actual translation.

It's only loaded when the Edit In Place feature is enabled.

@rvanlaak
Copy link
Member Author

It's only loaded when the Edit In Place feature is enabled.

That's interesting, as we don't disable it for our prod environment, but that's the only environment where debug = false.

... the main problem is that when developing we should include the Twig |raw filter with these translations, but we forget that because EditInPlace did set is_safe.

I totally understand that it is required in case EditInPlace is enabled, but not when the container gets compiled right? Would there be another way to solve this? Could the EditInPlaceResponseListener help with this?

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2017

We have to dynamically change the escaping of the response. See #102

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2017

Closed by #102

@Nyholm Nyholm closed this Jun 15, 2017
@Nyholm Nyholm deleted the rvanlaak-patch-1 branch June 15, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants