Update symfony usage #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2018
bronek89
reviewed
Jan 29, 2018
| Make sure `httpkernel` can access the Symfony session service. Add this to `services.yml`: | ||
|
|
||
| session.handler: | ||
| public: true |
There was a problem hiding this comment.
Does it work? I've tried it on symfony 4 and only solution that works was - #60 (comment)
There was a problem hiding this comment.
after adding these lines, following error appears:
In CheckDefinitionValidityPass.php line 60:
The definition for "session.handler" has no class. If you intend to inject this service dynamically at runtime, please mark it as synthetic=true. If this is an abstract definition solely used by child definit
ions, please add abstract=true, otherwise specify a class to get rid of this error.
There was a problem hiding this comment.
Could you check if declaring the service as synthetic works? See https://symfony.com/doc/current/service_container/synthetic_services.html for how to.
|
I've fixed that in master, no need for a workaround like that anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.