Symfony Deprecations

[kelunik]

I'm getting the following deprecation notices sometimes when pressing Ctrl + C.

User Deprecated: Requesting the "session.storage.metadata_bag" private service is deprecated since Symfony 3.2 and won't be supported anymore in Symfony 4.0.
User Deprecated: Setting the "session.storage.native" pre-defined service is deprecated since Symfony 3.3 and won't be supported anymore in Symfony 4.0.

[andig]

@kelunik do you have a suggestion how to fix these? I don't have any knowledge of symfony :/

[kelunik]

Same here.

[Richard87]

I have a suggestion, that seems to work for me under extremeley limited testing:

We need to modify the container before it is compiled, and as far as I know, the only place to do that is in AppKernel::build(), so to solve that, I extend the class, and override the service definition with our StrongerNativeSessionStorage.

Apparantly we have to do that everywhere we use $container->get("xxx");
(This is tested on PHP7.1 / Symfony 3.4)

        $definition = new Definition(StrongerNativeSessionStorage::class,[
            new Reference('session.storage.options'),
            new Reference('session.handler', \Symfony\Component\DependencyInjection\ContainerInterface::NULL_ON_INVALID_REFERENCE)
        ]);
        if (class_exists('\AppKernel')) {
            $app = new class($this->appenv, $this->debug) extends \AppKernel {
                protected function build(\Symfony\Component\DependencyInjection\ContainerBuilder $container)
                {
                    parent::build($container);
                    $container->setDefinition('session.storage.native', $definition);
                }
            };
        } else {
            $app = new class($this->appenv, $this->debug) extends \App\Kernel {
                protected function build(\Symfony\Component\DependencyInjection\ContainerBuilder $container)
                {
                    parent::build($container);
                    $container->setDefinition('session.storage.native', $definition);
                }
            };
        }

[Richard87]

And some good news 💯

Symfony created a Kernel::reboot() method that will simplify everything ;)

    /**                                                                                                                           
     * Does some necessary preparation before each request.                                                                       
     *                                                                                                                            
     * @param \AppKernel $app                                                                                                     
     */                                                                                                                           
    public function preHandle($app)                                                                                               
    {                                                                                                                             
        Utils::hijackProperty($app, 'startTime', microtime(true));                                           
                                                                                                             
        if (method_exists($app, "reboot"))                                                                   
            return $app->reboot(null);                                                                       
    }                                                                                                        
                                                                                                             
    /**                                                                                                      
     * Does some necessary clean up after each request.                                                      
     *                                                                                                       
     * @param \AppKernel $app                                                                                
     */                                                                                                      
    public function postHandle($app)                                                                         
    {                                                                                                        
        if (method_exists($app, "reboot"))                                                                   
            return;       

        // Legacy code                                                                                   
        $container = $app->getContainer();                                                                   
                                             

[Richard87]

Or even better, reboot it when the old request is done, so it's ready for the next request:

    /**                                                                                                                           
     * Does some necessary preparation before each request.                                                                       
     *                                                                                                                            
     * @param \AppKernel $app                                                                                                     
     */                                                                                                                           
    public function preHandle($app)                                                                                               
    {                                                                                                                             
        Utils::hijackProperty($app, 'startTime', microtime(true));                                                                  
    }                                                                                                        
                                                                                                             
    /**                                                                                                      
     * Does some necessary clean up after each request.                                                      
     *                                                                                                       
     * @param \AppKernel $app                                                                                
     */                                                                                                      
    public function postHandle($app)                                                                         
    {                                                                                                        
        if (method_exists($app, "reboot"))                                                                   
            return $app->reboot(null);       

        // Legacy code                                                                                   
        $container = $app->getContainer();    

[marcj]

Reboot destroys the whole container, doesn't it? That will make the whole php-pm useless as its then almost as slow as PHP-FPM.

[Richard87]

yeah, I think I just noticed that :/

EDIT I'm not sure it destroys the container, it should reset all services etc...

[bronek89]

Hi :)
Quick fix for using Symfony 4 with ppm now, is to use something like this in your app kernel:

protected function build(ContainerBuilder $container): void
    {
        parent::build($container);

        $container->addCompilerPass(
            new class implements CompilerPassInterface
            {
                /**
                 * You can modify the container here before it is dumped to PHP code.
                 */
                public function process(ContainerBuilder $container)
                {
                    $container->getDefinition('session.storage.native')->setPublic(true);
                }
            }
        );
    }

At least for problem with "session.storage.native"

[GromNaN]

The StrongerNativeSessionStorage provide a generic patch on a behaviour that would affect any other server implemented in PHP.

It might be possible to port this patch into Symfony itself, with some sort of feature flag/detection.

Also, not every Symfony application needs sessions, the injection of the session storage should be optional.

[andig]

@kelunik is this still an issue with current http kernel or could this issue be closed?

[kelunik]

You'll need to test that, I've no idea.

[andig]

Closing for time being as no further reports of this issue have been received.