Skip to content

Fix broken provide rule #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix broken provide rule #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"provide": {
"php-http/client-implementation": "1.0",
"psr/http-client": "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace it in favor psr/http-client-implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your comment. this package does not provide and does not replace psr/http-client, which is the package providing the PSR ClientInterface. It even requires psr/http-client (which is probably why things work in Composer 1).

And my Pr has not change the fact that this package provides php-http/client-implementation (the line is edited only to remove the comma, as JSON does not support trailing commas in objects)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, that this package should provide implementations for 2 packages:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, indeed, I missed that the existing line was for php-http/client and not psr/http-client

"psr/http-client-implementation": "1.0"
},
"autoload": {
"psr-4": {
Expand Down