-
Notifications
You must be signed in to change notification settings - Fork 42
Fix broken provide rule #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -22,8 +22,7 @@ | |||
"php-http/client-common": "^2.0" | |||
}, | |||
"provide": { | |||
"php-http/client-implementation": "1.0", | |||
"psr/http-client": "1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace it in favor psr/http-client-implementation
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your comment. this package does not provide and does not replace psr/http-client
, which is the package providing the PSR ClientInterface. It even requires psr/http-client
(which is probably why things work in Composer 1).
And my Pr has not change the fact that this package provides php-http/client-implementation
(the line is edited only to remove the comma, as JSON does not support trailing commas in objects)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, that this package should provide implementations for 2 packages:
psr/http-client-implementation
(https://packagist.org/?query=psr%2Fhttp-client-implementation)php-http/client-implementation
(https://packagist.org/?query=php-http%2Fclient-implementation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, indeed, I missed that the existing line was for php-http/client
and not psr/http-client
This package provides the client implementation. But it does not provide the interfaces from psr/http-client
This is now fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
What's in this PR?
This package provides the client implementation. But it does not provide the interfaces from psr/http-client
Why?
Which problem does the PR fix? (remove this section if you linked an issue above)
Example Usage
Checklist
To Do