Fixes #31: Wrong parameters error when TimeoutException is thrown #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
reviewed
Nov 14, 2017
src/Exception/StreamException.php
Outdated
| * @param long $code | ||
| * @param Exception $previous | ||
| */ | ||
| public function __construct($message = null, RequestInterface $request = null, $code = null, $previous = null) |
There was a problem hiding this comment.
Using $request as second constructor argument is a BC break. You must put it last to be BC.
|
Thanks for this PR and the correction aftewards, will release a new version in december |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the StreamException to accept optional Request as second param