Skip to content

Timeout exceeded cause php fatal/throwable error #31

Closed
@insidieux

Description

@insidieux

This commit have been broken behavior when request timeout exceeded. When this code evaluated, we'll get fatal/throwable error like this:

Wrong parameters for Http\Client\Socket\Exception\TimeoutException([string $message [, long $code [, Throwable $previous = NULL]]]) (uncaught exception) at /vendor/php-http/socket-client/src/ResponseReader.php line 51 while running console command 
#0 /vendor/php-http/socket-client/src/ResponseReader.php(51): Exception->__construct('Error while rea...', Object(GuzzleHttp\Psr7\Request))

This error happens cause current TimeoutException extendw default php \RuntimeException, although previous NetworkException use RuntimeException, which has different controller and arguments (second argument is request object)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions