Skip to content

Upgrade CI to GitHub workflow. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Upgrade CI to GitHub workflow. #43

merged 1 commit into from
Dec 17, 2020

Conversation

shulard
Copy link
Collaborator

@shulard shulard commented Dec 16, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

The CI system is migrated from Travis to GitHub Actions. The workflow was taken from php-http/message repository which seems to have the more complete configuration.

Why?

Since travis is not reliable anymore for OSS projects, we must move to the new GitHub feature.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • Is Scrutinizer still used somewhere ?

@shulard
Copy link
Collaborator Author

shulard commented Dec 16, 2020 •
edited
Loading

Maybe this change requires some tweaks in the project configuration…

@shulard shulard force-pushed the chore/move-to-github-actions branch 3 times, most recently from e37c1dd to 8d548a5 Compare December 16, 2020 12:11
@shulard shulard changed the title chore(ci): Now use GitHub workflows. Upgrade CI to GitHub workflow. Dec 16, 2020
dbu
dbu reviewed Dec 16, 2020
View reviewed changes
dbu
dbu reviewed Dec 16, 2020
View reviewed changes
@shulard shulard force-pushed the chore/move-to-github-actions branch from 8d548a5 to 4636b4e Compare December 16, 2020 13:25
@dbu
Copy link
Contributor

dbu commented Dec 16, 2020

we seem to use an antique phpunit in this repository. can you try with ^8.5 instead of the version 4 and 5? (and i think we see an example of "php": ">=5.4" or something here... phpunit 7 would correctly report that it does not work on php 8. (though phpunit 9 seems to have dropped this again and goes with >=)

@shulard
Copy link
Collaborator Author

shulard commented Dec 16, 2020

Yes you're right about phpunit. But I think we must work on merging the #42 first instead of this one. In the #42, I removed the direct dependency to PHPUnit and let the php-http/client-integration-tests package define the correct version to use. This adapter package doesn't have any direct interaction with PHPUnit 😄.

So I'm pretty sure that after merging #42, this phpunit version problem will disappear !

@shulard shulard force-pushed the chore/move-to-github-actions branch from 4636b4e to e1793aa Compare December 17, 2020 13:56
@shulard
Copy link
Collaborator Author

shulard commented Dec 17, 2020

Hello !

I just rebased this branch on master and it seems that the workflow is now passing: https://github.com/shulard/react-adapter/runs/1570693771

dbu
dbu approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@shulard shulard merged commit 16e7abd into php-http:master Dec 17, 2020
@shulard shulard deleted the chore/move-to-github-actions branch December 17, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulard @dbu