Upgrade to react/http instead of react/http-client which is deprecated.

[shulard]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Related tickets	fixes #41
License	MIT

What's in this PR?

The adapter now rely on react/http instead of react/http-client. The Client external behaviour hasn't changed but all the inner logic is now rewritten.

Because react/http hasn't a compatible signature with react/http-client this is a BC Break and will require a new major version of the adapter.

Why?

react/http-client is now deprecated so we must move with the ecosystem.

Checklist

• Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• Documentation pull request created (if not simply a bugfix)

[dbu]

thanks! this seems good to me.

can you maybe adjust the style-ci configuration to the newest symfony ruleset (remove the explicit rule that is now in the symfony ruleset)?

should we bump this to a new major version? it could be unexpected to have the underlying react library change completely when upgrading.

[shulard]

Ok I take a look at the style-ci configuration. For sure it must be a new major version for this adapter. If some users have tweaked the reactphp behaviour, their code will not work anymore.

[dbu]

please change composer.json where it says

    "extra": {
        "branch-alias": {
            "dev-master": "2.4-dev"

to say 3.x-dev

we did not release the last commit to master as 2.4 yet - it was the switch to httplug 2. however, i think the correct way is to get this merged as well, rather than a release 2.4 for the switch to httplug 2. do you agree?

[shulard]

Ok, I've just updated the composer.json file…

Maybe we can release the two different tags. I think that users can have advantage to use the httplug 2 no ? Maybe we'll have to path the v2 branch at some time… It'll require a tiny changelog update for the v2.4.0 branch to be published.

[dbu]

my thinking was that we could merge this and release as 3.0.0 immediately. i would not be aware of other BC breaking things we need to do. that would keep the number of different versions a bit lower. and it might be problematic for some when we switch to httplug 2 in a minor version...

[shulard]

You're absolutely right 😄. I close the #44 and merge this one. Then I'll commit the changelog update on master for the v3.0.0 release 😉.

[dbu]

hooray, thanks!