Use php-http/promise for the async interface #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't actually be merged until the Promise getResponse/getException methods are removed from everywhere. |
|
Yeah but we need this to be merged to upgrade other libs :) |
|
We can rely on the feature branch for the time being, then magically merge everything at the same time. |
This was referenced Dec 13, 2015
|
All pr are done IMO |
sagikazarmark
added a commit
that referenced
this pull request
Dec 13, 2015
Use php-http/promise for the async interface
Nyholm
pushed a commit
to Nyholm/httplug
that referenced
this pull request
Dec 26, 2019
Move the exception symbol one step up in the stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like discussed in #86