Update async calls with new package and interface #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feature/promise
branch
from
886b6a5 to
d1a61a7
Compare
| try { | ||
| $this->call($this->onRejected, $this->exception); | ||
| } catch (Exception $exception) { | ||
| $this->exception = $exception; |
There was a problem hiding this comment.
This will replace exception related to request with exception related to callback code. Why?
There was a problem hiding this comment.
I guess the callback should handle the exception or rethrow it. But @joelwurtz is the promise master in da house.
mekras
added a commit
that referenced
this pull request
Dec 14, 2015
Update async calls with new package and interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See php-http/httplug#90