Skip to content

Added a note about no body for GET requests #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 2, 2016
Merged

Added a note about no body for GET requests #131

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bf6949
Added a note about no body for GET requests
Nyholm Jul 28, 2016
6a8e15d
Removed extra line
Nyholm Jul 28, 2016
d82d018
Fixed typo
Nyholm Aug 2, 2016
3ab3334
Update buzz-adapter.rst
Nyholm Aug 2, 2016
1d198ad
Update spelling_word_list.txt
Nyholm Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clients/buzz-adapter.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ Or if you installed the :doc:`discovery </discovery>` layer::

The message factory parameter is mandatory if the discovery layer is not installed.

Be aware
--------

This adapter violates the Liskov substitution principle in a rare edge case. When the adapter is configured to use
Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A RequestException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RequestException (with backticks) ?

will be thrown if this ever happens.
Copy link
Contributor

@dbu dbu Aug 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add: "The only solution if you need GET requests with a body (e.g. for Elasticsearch) is to use [whatever] in Buzz or a different client like Guzzle 6.


.. include:: includes/further-reading-sync.inc

.. _Buzz HTTP client: https://github.com/kriswallsmith/Buzz
1 change: 1 addition & 0 deletions spelling_word_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Diactoros
fallback
GitHub
hotfix
Liskov
Symfony
HTTPlug
Ivory
Expand Down