Added a note about no body for GET requests #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| This adapter violates the Liskov substitution principle in a rare edge case. When the adapter is configured to use | ||
| Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A RequestException | ||
| will be thrown if this ever happens. |
There was a problem hiding this comment.
lets add: "The only solution if you need GET requests with a body (e.g. for Elasticsearch) is to use [whatever] in Buzz or a different client like Guzzle 6.
|
The PR is updated. There is no workaround for this limitation BTW. It is a limitation in Buzz. |
|
doesn't buzz have other clients than curl? it looks like you need to add Elasticsearch to the dictionary. |
True. The PR is updated |
|
👍 |
|
Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing this in the documentation makes us more serious.