we don't support php 5.4 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, but hhvm setup seems to be broken |
|
HHVM is an ugly bitch IMHO when it comes to cURL. PHP 7 can be enabled for this repo, but not for others, where PHPSpec is used, as 2.4 is not stable yet. |
|
I have never dealt with HHVM. So I just copied existed setup from boilerplate. |
|
i will see what i can do about HHVM
|
|
As I can see, there is a problem with the integration test suite. |
|
there seems to also be an issue with the lowest version getting a too
old version of phpunit token stream
|
|
Code coverage fixed. |
|
Tests currently needs PHP builtin server. So they can not run under HHVM. Add skipping them for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i activated travis for this repository and noticed it tries to build with php 5.4, then composer notices that this wont work.
i suggest we activate php 7 as well. its about to be released, and currently green.