Use the curl_reset function to allow resource reusing #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could there be an issue with async requests? or can curl never do async anyways? |
|
Actually we could backport curl_reset to PHP 5.4. Is that possible at all? Maybe we could check if there is a symfony pollyfill for it. |
|
It's not possible to create a polyfill to curl_reset. I've already tried to find a way to do that but we can't unset a config, we can just set its value. I think that this PR is not a problem about the async thing, we just need to ensure that all is fine when async implementation is done. |
|
i would not even try to support php 5.4. its end of life. see also #2
|
|
Yeah, if there is 1% need for PHP 5.5, use it. |
mekras
added a commit
that referenced
this pull request
Nov 11, 2015
Use the curl_reset function to allow resource reusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the PHP required version is 5.5, we can rely on the
curl_resetfunction to manage curl handle.It allow us to avoid create a new resource for each call. I've faced to some problem without reusing handles on previous project. Since that I always use that. It just reset all the attached option to the current handle.