Add non-symlink case to bin/http_test_server #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Sep 23, 2020
|
Is this ready to merge? |
|
I don't plan any more changes from my side. |
|
If you are “pretty sure” it works, the it is good enough for me. |
|
Hm.. I tested on Guzzle and it does not work properly... Maybe Im doing something wrong: guzzle/guzzle#2790 |
|
It looks like you did everything correctly. I'll try in my personal fork later to see where it's still going wrong, because I don't want to leave loose ends here. Thanks. |
|
For the record: I found the issue in @Nyholm's PR and added a review with a suggested change to his PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR hopefully adds direct support for running bin/http_test_server on Windows. Details are in #46.
I tested this PR by removing the other conditions and then running the script on Ubuntu. It worked fine. I did not actually test this on Windows, but I am confident that it should work properly. In any case we are not worse off compared to the situation before.
Example Usage
n/a
Checklist
To Do