Skip to content

output error message if we can't start a php server #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

output error message if we can't start a php server #47

merged 1 commit into from
Sep 23, 2020

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Sep 23, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #46
License MIT

Improve DX when we fail to start a web server

@dbu dbu mentioned this pull request Sep 23, 2020
Closed
TimWolla
TimWolla suggested changes Sep 23, 2020
View reviewed changes
TimWolla
TimWolla approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Looks good to me now. Thanks!

@dbu @TimWolla
output error message if we can't start a php server
9a26b40 
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
@dbu
Copy link
Contributor Author

dbu commented Sep 23, 2020

thanks a lot for reporting this!

Nyholm
Nyholm approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dbu dbu merged commit 4daae3f into master Sep 23, 2020
@dbu dbu deleted the explicit-error branch September 23, 2020 09:37
@dbu
Copy link
Contributor Author

dbu commented Sep 23, 2020

the build of this package itself does look like it needs some love. but the change in this PR does not break that part, so i still merged it.

@TimWolla TimWolla mentioned this pull request Sep 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bin/http_test_server not functional on Windows
3 participants
@dbu @TimWolla @Nyholm