Skip to content

Replacement upgrade phpspec-code-coverage #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Replacement upgrade phpspec-code-coverage #195

merged 1 commit into from
Jul 1, 2020

Conversation

GrahamCampbell
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #188
License MIT

Co-Authored-By: Dan Michael O. Heggø d.m.heggo@ub.uio.no

@GrahamCampbell GrahamCampbell marked this pull request as draft July 1, 2020 14:27
Co-Authored-By: Dan Michael O. Heggø <d.m.heggo@ub.uio.no>
@GrahamCampbell
Copy link
Contributor Author

Travis didn't run?

@dbu
Copy link
Contributor

dbu commented Jul 1, 2020

weird. maybe its still in the queue? it did run on the other MR that you marked as draft, right? or maybe it is running but not updating github?

@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 1, 2020 14:41
@GrahamCampbell GrahamCampbell deleted the code-coverage branch July 1, 2020 14:41
@GrahamCampbell GrahamCampbell restored the code-coverage branch July 1, 2020 14:41
@GrahamCampbell GrahamCampbell reopened this Jul 1, 2020
@GrahamCampbell
Copy link
Contributor Author

Travis does seem to have triggered, but not pushed the build status to GitHub: https://travis-ci.org/github/php-http/client-common/builds/703951705.

@GrahamCampbell
Copy link
Contributor Author

Build passed:

image

@dbu dbu merged commit 052d4d4 into php-http:master Jul 1, 2020
@dbu
Copy link
Contributor

dbu commented Jul 1, 2020

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants