Upgrade to friends-of-phpspec/phpspec-code-coverage

[danmichaelo]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #181
Documentation	–
License	MIT

Why?

Since leanphp/phpspec-code-coverage is abandoned, we should switch to friends-of-phpspec/phpspec-code-coverage.

Checklist

• [ ] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• [ ] Documentation pull request created (if not simply a bugfix)

Note

I noticed that phpspec/phpspec:^4.2 is required in .travis.yml, while phpspec/phpspec": "^5.1 || ^6.0 is required in composer.json. Perhaps they should be aligned?

[dbu]

thanks!

with the phpspec requirement: indeed. if we require phpspec in the composer.json anyways, we should be able to simply remove it from the .travis.yml file, right?

[dbu]

i tried seeing if that works in the travis-ci build. but it seems like some builds are not even built? we have 4 builds, but 6 jobs in the .travis file... do you happen to see whats wrong here?

[xabbuh]

@dbu The matrix option seems to have overwritten the jobs config (see https://travis-ci.org/github/php-http/client-common/builds/687169121/config and the fix in #189).

[danmichaelo]

thanks!

with the phpspec requirement: indeed. if we require phpspec in the composer.json anyways, we should be able to simply remove it from the .travis.yml file, right?

Would you be ok with having both phpspec and phpspec-code-coverage only in composer.json? While neither are really needed in all the builds, installing them from .travis.yml instead of having them in composer.json seems like a type of micro-optimization not really worth it.

One reason not to include phpspec-code-coverage in composer.json could be if you needed to support older versions of PHP than the version phpspec-code-coverage supports though. Perhaps that was the case in the past at one point? But now everything requires 7.1, and in general it seems like the PHP world moves a bit more concerted to new versions than it did in the past, where there was for instance a discrepancy between those libraries that maintained 5.6 support and those that didn't.

I'm also unsure why phpunit and nyholm/psr7 are installed from .travis.yml, as they are also in composer.json. Perhaps that should be the topic of a separate PR though

[dbu]

yeah lets use the require-dev for all those. can you please rebase this PR on master to get the matrix fix in, and then move those dependencies to require-dev? we then see if we missed anything about php 7.1 support...

[GrahamCampbell]

Replacement PR: #195.