Skip to content

Enhancement: Configure visibility_required fixer #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enhancement: Configure visibility_required fixer #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .php_cs.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,12 @@ return PhpCsFixer\Config::create()
],
'no_empty_phpdoc' => true,
'no_superfluous_phpdoc_tags' => true,
'visibility_required' => [
'elements' => [
'const',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure if

boilerplate/composer.json

Line 14 in 948e25e

"php": "^5.5 || ^7.0"
make sense, then.

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we built this back when we started with php 5.5 - i guess the boilerplate should say 7.1, as if we start anything new or update that stuff in any project, we should start with php 7.1

'method',
'property',
],
],
])
->setFinder($finder);