Skip to content

Enhancement: Configure visibility_required fixer #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

localheinz
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets php-http/HttplugBundle#349 (comment)
Documentation n/a
License MIT

What's in this PR?

This PR

  • configures the visibility_required fixer

@@ -19,5 +19,12 @@ return PhpCsFixer\Config::create()
],
'no_empty_phpdoc' => true,
'no_superfluous_phpdoc_tags' => true,
'visibility_required' => [
'elements' => [
'const',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure if

"php": "^5.5 || ^7.0"
make sense, then.

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we built this back when we started with php 5.5 - i guess the boilerplate should say 7.1, as if we start anything new or update that stuff in any project, we should start with php 7.1

@localheinz localheinz closed this Mar 6, 2020
@localheinz localheinz deleted the feature/visibility-required branch March 6, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants