Skip to content

Fix: Drop support for unsupported PHP versions #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented May 30, 2019

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets #333
Documentation n/a
License MIT

What's in this PR?

This PR

Why?

The build is currently broken as php-http/vcr-plugin:^1.0@dev requires PHP 7.1.

Example Usage

n/a

Checklist

  • Updated CHANGELOG.md to describe BC breaks

To Do

n/a

@localheinz localheinz force-pushed the fix/php branch 3 times, most recently from 4db0809 to 4332466 Compare May 30, 2019 20:35
@localheinz
Copy link
Contributor Author

Looks like this doesn't actually fix the build, but requires more work.

@dbu
Copy link
Collaborator

dbu commented May 31, 2019

thanks.

looking at https://travis-ci.org/php-http/HttplugBundle/jobs/539402830 i think its also time to ditch symfony 2 support, wdyt?

a lot of builds are red because of deprecations that are not actual bugs. we might still adjust to avoid the deprecation to be future proof.

@dbu
Copy link
Collaborator

dbu commented Jun 4, 2019

did all of the removing old stuff in #340
thanks for getting the ball rolling here !

@dbu dbu closed this Jun 4, 2019
@localheinz localheinz deleted the fix/php branch June 4, 2019 09:53
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants